[PATCH] D113572: [DebugInfo] run clang-format on some unformatted files

[Luís Ferreira via Phabricator via llvm-commits]

ljmf00 added a comment.

@probinson Can you check now? If it looks good, can you land it, please?



================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:1780
+  /// encode the raw values provided. \p BD: base discriminator \p DF:
+  /// duplication factor \p CI: copy index The return is None if the values
+  /// cannot be encoded in 32 bits - for example, values for BD or DF larger
----------------
probinson wrote:
> This reflowing is awkward.  Try moving each \p to a new line, and maybe indent a couple of spaces, see if that causes clang-format to behave better.  You might need an empty `///` line before the \p lines.
I added a blank `///` similar to the above documentation.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2145
+  DEFINE_MDNODE_GET(DILexicalBlock,
+                    (DILocalScope * Scope, DIFile *File, unsigned Line,
+                     unsigned Column),
----------------
probinson wrote:
> Try removing the space before `Scope` and see if clang-format will preserve that.
clang-format insists on this, because of the macro.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2196
+  DEFINE_MDNODE_GET(DILexicalBlockFile,
+                    (DILocalScope * Scope, DIFile *File,
+                     unsigned Discriminator),
----------------
probinson wrote:
> And another `Scope` with an incorrect space.
It is very weird because the second parameter doesn't get indented.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113572/new/

https://reviews.llvm.org/D113572