[PATCH] D113606: [gn build] Fix Android compiler-rt targets

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/utils/gn/build/BUILD.gn:272
       cflags += [ "/winsysroot" + rebase_path(sysroot, root_build_dir) ]
     } else if (current_os != "ios" && current_os != "mac") {
       cflags += [ "--sysroot=" + rebase_path(sysroot, root_build_dir) ]
----------------
Maybe this should be
```
} else if (current_os != "ios" && current_os != "mac" && current_os != "android") {
```
instead? (Random thought: maybe we should change how `sysroot` works to better support cross compilation -- maybe a different variable for each target OS? -- but not as part of this change, I imagine.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113606/new/

https://reviews.llvm.org/D113606