[PATCH] D113572: [DebugInfo] run clang-format on some unformatted files

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 12:26:08 PST 2021


ljmf00 added a comment.

In D113572#3122004 <https://reviews.llvm.org/D113572#3122004>, @probinson wrote:

> In general doing a clang-format before extensive work on some files is an obvious NFC, but I can see why you might have wanted some review on this.
>
> LGTM, although the one thing I'd really like you to try is reflowing that one awkward function description.  All the other trivial spacing stuff is purely optional.

Thanks for the review! I'm aware that such code style patches don't need approval, according to the LLVM developers policy, but since I'm currently an outside contributor without commit access, I'm obligated to do it. I think these are also good for me to get used to this nit things clang-format is not able to fix, although I don't expect any extensive review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113572/new/

https://reviews.llvm.org/D113572



More information about the llvm-commits mailing list