[llvm] a8abd19 - [x86] simplify code; NFC
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 10 10:30:08 PST 2021
Author: Sanjay Patel
Date: 2021-11-10T13:29:57-05:00
New Revision: a8abd19b1073e0019ffe2b538cea5e9e0c6b9a27
URL: https://github.com/llvm/llvm-project/commit/a8abd19b1073e0019ffe2b538cea5e9e0c6b9a27
DIFF: https://github.com/llvm/llvm-project/commit/a8abd19b1073e0019ffe2b538cea5e9e0c6b9a27.diff
LOG: [x86] simplify code; NFC
We bail out if the types don't match, so it's clearer to
have a single variable to show that common type.
Added:
Modified:
llvm/lib/Target/X86/X86ISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 7633dfe39bf6..373a6619a0d1 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -45801,10 +45801,8 @@ static SDValue combineAndMaskToShift(SDNode *N, SelectionDAG &DAG,
const X86Subtarget &Subtarget) {
SDValue Op0 = peekThroughBitcasts(N->getOperand(0));
SDValue Op1 = peekThroughBitcasts(N->getOperand(1));
- EVT VT0 = Op0.getValueType();
- EVT VT1 = Op1.getValueType();
-
- if (VT0 != VT1 || !VT0.isSimple() || !VT0.isInteger())
+ EVT VT = Op0.getValueType();
+ if (VT != Op1.getValueType() || !VT.isSimple() || !VT.isInteger())
return SDValue();
APInt SplatVal;
@@ -45816,17 +45814,17 @@ static SDValue combineAndMaskToShift(SDNode *N, SelectionDAG &DAG,
if (isBitwiseNot(Op0))
return SDValue();
- if (!supportedVectorShiftWithImm(VT0.getSimpleVT(), Subtarget, ISD::SRL))
+ if (!supportedVectorShiftWithImm(VT.getSimpleVT(), Subtarget, ISD::SRL))
return SDValue();
- unsigned EltBitWidth = VT0.getScalarSizeInBits();
+ unsigned EltBitWidth = VT.getScalarSizeInBits();
if (EltBitWidth != DAG.ComputeNumSignBits(Op0))
return SDValue();
SDLoc DL(N);
unsigned ShiftVal = SplatVal.countTrailingOnes();
SDValue ShAmt = DAG.getTargetConstant(EltBitWidth - ShiftVal, DL, MVT::i8);
- SDValue Shift = DAG.getNode(X86ISD::VSRLI, DL, VT0, Op0, ShAmt);
+ SDValue Shift = DAG.getNode(X86ISD::VSRLI, DL, VT, Op0, ShAmt);
return DAG.getBitcast(N->getValueType(0), Shift);
}
More information about the llvm-commits
mailing list