[PATCH] D110527: [llvm-reduce] Add MIR support.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D110527#3121915 <https://reviews.llvm.org/D110527#3121915>, @bjope wrote:

> The IR part can often be eliminated from a MIR based test case. But sure, one could argue that when running llvm-reduce it could be mandatory to add an IR section in the .mir file first (but then I think one needs to also add the function prototype).

I can maybe see this as an argument for allowing override of the triple, but not as an argument for not defaulting to the triple if present.  Frankly, I find even the override case unconvincing.

And if MIR format doesn't allow an empty-except-for-DL/triple module, that's a bug in the parser/printer and we should just fix that.

Just to be clear here, I'm happy to do the work to adjust this.  I'm just trying to make sure I'm not missing some subtlety in the interface before investing the time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110527/new/

https://reviews.llvm.org/D110527