[PATCH] D113577: [SCEV] Support rewriting ZExt expressions with loop guard info.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:13725
+    return I->second;
+  }
 };
----------------
Can you please add a test where you both have a condition on %x and on `zext %x`? I think we'll end up losing the information from the direct condition in that case.

Something I also find odd here is the mismatch between the code collecting rewrites and the visitor. We'll collect rewrites on all SCEVs, but then only rewrite unknown and zext.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113577/new/

https://reviews.llvm.org/D113577