[PATCH] D113569: [flang][nfc] Add missing headers in TypeConverter.h

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 09:09:10 PST 2021


clementval added a comment.

In D113569#3121628 <https://reviews.llvm.org/D113569#3121628>, @awarzynski wrote:

> In D113569#3121587 <https://reviews.llvm.org/D113569#3121587>, @clementval wrote:
>
>> We should also probably clean up `CodeGen.cpp` while adding the headers here.
>
> I can trim the list of `#include`s in CodeGen.cpp, but there's a danger that I remove something that *is* used (but everything will build fine as it will be included with some other header file). Or did you you have something else in mind?

That's what I had in mind. Some includes are in CodeGen.cpp only for TypeConverter.h



================
Comment at: flang/lib/Optimizer/CodeGen/TypeConverter.h:251
     default:
-      emitError(UnknownLoc::get(&getContext()))
+      emitError(mlir::UnknownLoc::get(&getContext()))
           << "unsupported type: !fir.real<" << kind << ">";
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113569/new/

https://reviews.llvm.org/D113569



More information about the llvm-commits mailing list