[PATCH] D113365: [LLD][COFF] Support GNU style == aliases

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 07:57:35 PST 2021


aykevl added a comment.

In D113365#3116356 <https://reviews.llvm.org/D113365#3116356>, @mstorsjo wrote:

> - While this works for creating an import library out of a def file only, analoguously to llvm-dlltool, one can't create similar aliases while actually linking (doing that requires a couple more tweaks in a couple places, at least).

Can you elaborate? With this fix I was able to link Windows binaries that referenced these aliases. The linker was able to resolve them to the correct, non-weak versions.

> - While this can replace some use cases of llvm-dlltool, for i386, there's nothing (yet) here that corresponds to dlltool's flag `-k`. (This is used for mingw-w64's system def files for i386, it's vital for producing the right kind of import library for stdcall functions.)

Thanks, good to know! Right now I'm not targeting i386 so that's not a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113365/new/

https://reviews.llvm.org/D113365



More information about the llvm-commits mailing list