[PATCH] D112843: [aarch64/mac] Correctly disassemble @TLVPPAGE(OFF) relocs

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/MachO/disassemble-arm64-tlv-modifers.s:7-9
+; RUN: llvm-objdump -rd %t.o | FileCheck %s --check-prefix=CHECK-OBJDUMP
+; RUN: llvm-objdump --macho -d --full-leading-addr --no-show-raw-insn %t.o \
+; RUN:     | FileCheck %s --check-prefix=CHECK-MACHO
----------------
jhenderson wrote:
> Optional, but you could slightly simplify the prefixes by dropping "CHECK-". Also, I have a personal preference for the inline edit for continuing RUN lines. The logic is that the indentation makes it clear that the second line is a continuation, whilst the trailing `|` makes it clear that the first line is continued - again, entirely optional though.
Dropped the CHECK prefix, kept the indentation :) Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112843/new/

https://reviews.llvm.org/D112843