[PATCH] D112232: [NVPTX] Add imm variants for surface and texture instructions

[Andrew Savonichev via Phabricator via llvm-commits]

asavonic added a comment.

In D112232#3119329 <https://reviews.llvm.org/D112232#3119329>, @tra wrote:

> The changes look good in general. Thank you for cleaning this up.
>
> I'm still a bit concerned about all the boilerplate changes that we don't have good test coverage for. Granted, that's been the way since the initial implementation of texture/surface instructions and this patch is clearly an improvement.
> We may need to eventually autogenerate the tests for all instruction variants, similarly to what we do for *MMA instructions. https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/NVPTX/wmma.py

Agree. Independent test suite based on the PTX spec would be a really nice thing to have. I checked the patch several times and it seems there are no more errors, but it is really hard to verify without the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112232/new/

https://reviews.llvm.org/D112232