[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:769
+  Value *VecPtr = Builder.CreateBitCast(PtrOp, VecTyPtr);
+  (void)Builder.CreateStore(VecOp, VecPtr);
+  return IC.eraseInstFromFunction(II);
----------------
paulwalker-arm wrote:
> Is this necessary?
Adding `(void)` was my guidance, which on reflection I think was in error, thanks for pointing it out.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:788
+  auto VecPtr = Builder.CreateBitCast(PtrOp, VecTyPtr);
+  (void)Builder.CreateMaskedStore(VecOp, VecPtr, PtrOp->getPointerAlignment(DL),
+                                  Pred);
----------------
paulwalker-arm wrote:
> Is this necessary?
Adding `(void)` was my guidance, which on reflection I think was in error, thanks for pointing it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113489/new/

https://reviews.llvm.org/D113489