[PATCH] D113520: [SROA] Spill alloca's around non-capturing escapes via calls to allow alloca partitioning/promotion

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D113520#3120892 <https://reviews.llvm.org/D113520#3120892>, @lebedev.ri wrote:

> Some assortment of small improvements.
>
> In D113520#3119995 <https://reviews.llvm.org/D113520#3119995>, @jdoerfert wrote:
>
>> This is really cool.
>
> Yep.
>
>> There is a FIXME, are you expecting to address this? Other than that, reading through it seems sensible to me.
>
> I've added run line with `-opaque-pointers`, and everything appears to just work.
> @nikic - can you confirm that this is fine?

Actually thinking about it, that is obviously right,
because what opaque pointers disallow is *extracting*
the pointee type out of the pointer type,
and here we only get/use the whole pointer type,
so it doesn't matter if it contains the pointee knowledge or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113520/new/

https://reviews.llvm.org/D113520