[PATCH] D113553: [fir] Use contralized values for indexing box

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

Big thank you for this patch! IMHO it would be helpful to expand the comment, but it's already a big improvement as is!



================
Comment at: flang/lib/Optimizer/CodeGen/TypeConverter.h:24
 
+// Position of the different values in a box.
+static constexpr unsigned kAddrPosInBox = 0;
----------------
[nit] I appreciate that we do know what `box` this is referring to, but it might be unclear to somebody completely new to this code-base. Perhaps it's worth referring to the CFI struct? And `fir.box` instead of `box`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113553/new/

https://reviews.llvm.org/D113553