[PATCH] D112337: [DebugInfo] Only create concrete DIEs of concrete functions

[Adrian Kuegel via Phabricator via llvm-commits]

akuegel added a comment.

So unfortunately I was not able to create a standalone reproducer, but the crash happened when compiling the cord_internal target from Abseil with a clang build which includes your patch:

https://github.com/abseil/abseil-cpp/blob/master/absl/strings/BUILD.bazel#L268

The stack trace looks like this:

#0 0x000055c3d0823d78 llvm::sys::RunSignalHandlers()
 #1 0x000055c3d08263ac SignalHandler(int) 
 #2 0x00007f738ab60750 __restore_rt 
 #3 0x000055c3cf433a35 llvm::DIE::computeOffsetsAndAbbrevs(llvm::AsmPrinter const*, llvm::DIEAbbrevSet&, unsigned int)
 #4 0x000055c3cf433a56 llvm::DIE::computeOffsetsAndAbbrevs(llvm::AsmPrinter const*, llvm::DIEAbbrevSet&, unsigned int)
 #5 0x000055c3cf433a56 llvm::DIE::computeOffsetsAndAbbrevs(llvm::AsmPrinter const*, llvm::DIEAbbrevSet&, unsigned int)
 #6 0x000055c3cf47086f llvm::DwarfFile::computeSizeAndOffsets()
 #7 0x000055c3cf4421e8 llvm::DwarfDebug::finalizeModuleInfo()
 #8 0x000055c3cf4422c0 llvm::DwarfDebug::endModule()
 #9 0x000055c3cf40d81c llvm::AsmPrinter::doFinalization(llvm::Module&)
#10 0x000055c3d06ffda1 llvm::FPPassManager::doFinalization(llvm::Module&)
#11 0x000055c3d06f9dc2 llvm::legacy::PassManagerImpl::run(llvm::Module&)
#12 0x000055c3ccbdb248 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, std::__u::unique_ptr<llvm::raw_pwrite_stream, std::__u::default_delete<llvm::raw_pwrite_stream> >)
#13 0x000055c3ccbd6eb3 clang::CodeGenAction::ExecuteAction()
#14 0x000055c3cd4c0e7a clang::FrontendAction::Execute()
#15 0x000055c3cd439676 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) 
#16 0x000055c3cc8da5a6 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) 
#17 0x000055c3cc8cf131 cc1_main(llvm::ArrayRef<char const*>, char const*, void*)
#18 0x000055c3cc8cd4c2 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&)
#19 0x000055c3cc8cd2bf main


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112337/new/

https://reviews.llvm.org/D112337