[PATCH] D111555: [LoopVectorize] Add vector reduction support for fmuladd intrinsic

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 02:33:49 PST 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9644
+        VPInstruction *FMulRecipe =
+            new VPInstruction(Instruction::FMul, FMulOps);
+        FMulRecipe->setFastMathFlags(R->getFastMathFlags());
----------------
fhahn wrote:
> You should be able to use an initialiser list here `{VecOp, Plan->getVPValue(R->getOperand(1)}`.
Is it possible this change got missed when uploading the diff? The comment is marked as done, but the code still uses `SmallVector<> FMulOps`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111555/new/

https://reviews.llvm.org/D111555



More information about the llvm-commits mailing list