[PATCH] D113520: [SROA] Spill alloca's around non-capturing escapes via calls to allow alloca partitioning/promotion

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 02:24:43 PST 2021


lebedev.ri updated this revision to Diff 386102.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

Some assortment of small improvements.

In D113520#3119995 <https://reviews.llvm.org/D113520#3119995>, @jdoerfert wrote:

> This is really cool.

Yep.

> There is a FIXME, are you expecting to address this? Other than that, reading through it seems sensible to me.

I've added run line with `-opaque-pointers`, and everything appears to just work.
@nikic - can you confirm that this is fine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113520/new/

https://reviews.llvm.org/D113520

Files:
  llvm/lib/Transforms/Scalar/SROA.cpp
  llvm/test/Transforms/PhaseOrdering/lifetime-sanitizer.ll
  llvm/test/Transforms/SROA/non-capturing-call.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113520.386102.patch
Type: text/x-patch
Size: 61023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211110/5d31c590/attachment.bin>


More information about the llvm-commits mailing list