[PATCH] D113484: [fir] Add fir.select_case conversion

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 00:16:29 PST 2021


clementval marked an inline comment as done.
clementval added a comment.

In D113484#3120057 <https://reviews.llvm.org/D113484#3120057>, @pmccormick wrote:

> In D113484#3120018 <https://reviews.llvm.org/D113484#3120018>, @mehdi_amini wrote:
>
>> LGTM, would be nice if someone else would also have a look at it.
>
> Agree with @mehdi_amini -- looks good.   One minor typo in the `fir.select_case`first comments: //"A a point value..." //

Thanks I'll fix that. Can someone approve it then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113484/new/

https://reviews.llvm.org/D113484



More information about the llvm-commits mailing list