[PATCH] D113492: [llvm-profgen] Fix bug of split range branch sample

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 9 22:24:02 PST 2021


wlei added a comment.

> That shouldn't happen. Function calls has to go through prolog, and we shouldn't expect to see cross-function transfer in the middle of a function without going through prolog.

That makes sense. Abandon this patch, reverted to previous version.

update to mark the only range in the function as the entry and warn if no entry range exists.



================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:419
 
-  return FunctionSamples::getCanonicalFnName(FRange->getFuncName());
+  return FunctionSamples::getCanonicalFnName(TargetRange->getFuncName());
 }
----------------
hoy wrote:
> Can this filter out non-entry jumps that is from a different function to an outlined part of a function? I.e the Coro resume case
I see, it can't, abandon this patch, reverted to previous version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113492/new/

https://reviews.llvm.org/D113492



More information about the llvm-commits mailing list