[PATCH] D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object
Kyungwoo Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 9 18:01:56 PST 2021
kyulee updated this revision to Diff 386026.
kyulee added a comment.
Incorporated the feedback.
- Bookkeep the current line table for CU so that when a line entry needs to be emitted for different CU, terminate the current line table by injecting an end sequence.
- Didn't break this on section change, becuase the line table is already being tracked per section.
- Still didn't handle nodebug function case -- no debug function may span debug functions in the line table. Terminating the line table was a bit tricky becuse no debug function basically does not have a reference line entry. But I think this impreciion is less concern in practice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108261/new/
https://reviews.llvm.org/D108261
Files:
llvm/include/llvm/MC/MCContext.h
llvm/include/llvm/MC/MCDwarf.h
llvm/lib/MC/MCDwarf.cpp
llvm/test/DebugInfo/debugline-endsequence.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108261.386026.patch
Type: text/x-patch
Size: 7070 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211110/301b1964/attachment.bin>
More information about the llvm-commits
mailing list