[PATCH] D113528: [RISCV] Fix non-sensical intrinsic names in rv64i-single-softfloat.ll. NFC

Tue Nov 9 17:23:03 PST 2021

jrtc27 added a comment.

In D113528#3120203 <https://reviews.llvm.org/D113528#3120203>, @craig.topper wrote:

> In D113528#3120193 <https://reviews.llvm.org/D113528#3120193>, @jrtc27 wrote:
>
>> Looks like they've been broken the whole time; see D65497 <https://reviews.llvm.org/D65497>. Also no clue what fpround is meant to be, all seven (floor, ceil, trunc, rint, nearbyint, round, roundeven) of the rounding intrinsics are already tested (modulo the typos).
>
> This is the only place these are tested with softfloat isn't it?

Looks like it. I don't know why there aren't just RVxxI versions in the {float,double}-intrinsics.ll files; this seems like unnecessary duplication of effort, is under-tested due to not having any RV32I tests and rv64i-double-softfloat.ll is comparatively minimal.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113528/new/

https://reviews.llvm.org/D113528