[PATCH] D100672: [ADT] Add new type traits for type pack indexes

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

In D100672#3119835 <https://reviews.llvm.org/D100672#3119835>, @dblaikie wrote:

> In D100672#3119829 <https://reviews.llvm.org/D100672#3119829>, @scott.linder wrote:
>
>> Ping, @dblaikie are you OK with the patch as-is? I think it is likely not worth the effort of tracking down what MSVC configurations will accept the `constexpr` version.
>
> Fair enough. I really don't like to workaround unknown issues (ends up with a form of "fear based programming" - "let's not write code that looks like that because there are issues /somewhere/ in there" - haunted graveyards ( https://www.usenix.org/sites/default/files/conference/protected-files/srecon17americas_slides_reese.pdf ) , etc) - so I think there's significant value in figuring out exactly what the limitations are/what's being worked around - but I won't insist on it.

I wholeheartedly agree, but I think it will require (trivially) reproducible developer builds for all supported configurations to make that possible. As it stands, I can't access the builds which reproduce the failure, and my attempts at reproducing it with what I do have access to haven't amounted to anything :(

Thank you for the leeway, I won't make a habit of asking for it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100672/new/

https://reviews.llvm.org/D100672