[PATCH] D112716: AMDGPU: Account for implicit argument alignment for kernarg segment

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 9 12:44:43 PST 2021


kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.

LGTM

> The metadata treats the minimum as 16?

I found some internal docs that say the minimum must be 16, but those docs describe the time when kernarg segment alignment was a part of kernel descriptor. So I believe metadata just inherited that. I will find out if it should stay the same in metadata and update the amdgpu usage accordingly. thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112716/new/

https://reviews.llvm.org/D112716



More information about the llvm-commits mailing list