[PATCH] D113484: [fir] Add fir.select_case conversion
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 9 10:24:42 PST 2021
mehdi_amini added inline comments.
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:395
+
+/// Conversion of `fir.select_case`
+///
----------------
Can you expand a bit on the doc here? This isn't a 1-1 conversion, so it seems worth spelling it out.
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:417
+ auto caseArg = *cmpOps.begin();
+ auto &attr = cases[t];
+ if (attr.isa<fir::PointIntervalAttr>()) {
----------------
The `&` reference hear is misleading, I don't think it ever gets modified and `Attribute` is a value type
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:458
+ }
+};
+
----------------
Many types to spell out instead of `auto` in there, can you update please?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113484/new/
https://reviews.llvm.org/D113484
More information about the llvm-commits
mailing list