[PATCH] D113132: [InstCombine] Fuse checks for LHS (~(A | B) & C) | ... NFC.
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 9 09:29:41 PST 2021
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
In D113132#3117026 <https://reviews.llvm.org/D113132#3117026>, @rampitec wrote:
> With all that said it looks like these patterns have to be extracted into a separate function and called for both 'or' and 'and'. But I don't think this shall preclude this NFC and the next D113141 <https://reviews.llvm.org/D113141> to wait for it, these are mostly orthogonal to me.
I agree (just wanted to raise the idea of generalizing if possible) - this one looks like good cleanup / NFC. LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113132/new/
https://reviews.llvm.org/D113132
More information about the llvm-commits
mailing list