[PATCH] D108942: [compiler-rt] Add more diagnostic to InstrProfError

Gulfem Savrun Yeniceri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 9 08:57:21 PST 2021


gulfem added a comment.

In D108942#3087968 <https://reviews.llvm.org/D108942#3087968>, @davidxl wrote:

> I find it cleaner just to expand known malformed errors into its own error category. WIth that the change can also be minimized.

@davidxl, adding an optional diagnostic error message to `InstrProfError` gives us the flexibility to do that not only for malformed profiles, but for other kind of profile errors.
I only added for malformed profiles because it was our current use case. But, we can later extend it for other kind of profile issues.
This is why I would prefer not to have another error category for malformed profiles.
Please let me know what you think about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108942/new/

https://reviews.llvm.org/D108942



More information about the llvm-commits mailing list