[PATCH] D113447: [sancov] add tracing for loads and store

[Matt Morehouse via Phabricator via llvm-commits]

morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/Driver/autocomplete.c:73
 // FNOSANICOVERALL-NEXT: trace-pc-guard
+// FNOSANICOVERALL-NEXT: trace-loads
+// FNOSANICOVERALL-NEXT: trace-stores
----------------
This check is failing in the harbormaster build:  https://reviews.llvm.org/harbormaster/unit/view/1482705/


================
Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_loads_stores.cpp:5
+//
+// RUN: %clangxx -O0 %s -fsanitize-coverage=func,trace-loads,trace-stores -o %t
+// RUN: %run %t 2>&1 | FileCheck %s
----------------
According to the documentation update in this patch, these flags don't work without trace-pc or inline-8bit-counters.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:719-720
+      if (Options.TraceStores)
+        if (StoreInst *LD = dyn_cast<StoreInst>(&Inst))
+          Stores.push_back(LD);
       if (Options.StackDepth)
----------------
nit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113447/new/

https://reviews.llvm.org/D113447