[PATCH] D113405: [fir] Add !fir.logical type conversion

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: flang/test/Fir/types-to-llvm.fir:70
+// CHECK-LABEL: foo3
+// CHECK-SAME: i64
----------------
clementval wrote:
> kiranchandramohan wrote:
> > Assuming we do not support fir.logical<16>
> It's actually supported. Will add a test before landing this. 
> 
> ```
> func private @foo4(%arg0: !fir.logical<16>)
> // CHECK-LABEL: foo4
> // CHECK-SAME: i128
> ```
The front end only supports LOGICALs with KIND values of 1, 2, 4, and 8. (See, for example, `flang/Evaluate/type.h`.

FIR has no such restrictions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113405/new/

https://reviews.llvm.org/D113405