[PATCH] D113469: [fir] Add fir.convert op conversion from FIR to LLVM IR

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 4 inline comments as done.
clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:173
+      }
+    } else if (fromTy.isa<mlir::IntegerType>()) {
+      if (toTy.isa<mlir::IntegerType>()) {
----------------
awarzynski wrote:
> > Don’t use else after a return
> https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
> 
> Could you add a comment, e.g. "Conversion from integer types"?
The guidelines does not apply here. 
Comment added. 


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:193
+      }
+    } else if (fromTy.isa<mlir::LLVM::LLVMPointerType>()) {
+      if (toTy.isa<mlir::IntegerType>()) {
----------------
awarzynski wrote:
> > Don’t use else after a return
> https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
> 
> Could you add a comment, e.g. "// Conversion from pointer types"?
Comment added. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113469/new/

https://reviews.llvm.org/D113469