[PATCH] D113434: [fir] Add complex operations conversion from FIR LLVM IR

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

In D113434#3117833 <https://reviews.llvm.org/D113434#3117833>, @clementval wrote:

> In D113434#3117776 <https://reviews.llvm.org/D113434#3117776>, @kiranchandramohan wrote:
>
>> What triple will this assume by default? Does it depend on the platform that it runs? Will this fail on AArch64? I think tco assumed x86_64 if not specified.
>
> The conversion is the same for all target on this. `complexMemoryType` is shared for all targets.

func @fir_complex_add(%a: !fir.complex<16>, %b: !fir.complex<16>) -> !fir.complex<16> {

In D113434#3117833 <https://reviews.llvm.org/D113434#3117833>, @clementval wrote:

> In D113434#3117776 <https://reviews.llvm.org/D113434#3117776>, @kiranchandramohan wrote:
>
>> What triple will this assume by default? Does it depend on the platform that it runs? Will this fail on AArch64? I think tco assumed x86_64 if not specified.
>
> The conversion is the same for all target on this. `complexMemoryType` is shared for all targets.

I might be confused here. But aren't the arguments converted by `complexArgumentType` which is dependent on the target?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113434/new/

https://reviews.llvm.org/D113434