[PATCH] D111487: [XCOFF][yaml2obj] support for the auxiliary file header.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 9 02:31:39 PST 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:356
+  } else {
+    W.write<uint32_t>(InitAuxFileHdr.TextSize.getValueOr(yaml::Hex32(0)));
+    W.write<uint32_t>(InitAuxFileHdr.InitDataSize.getValueOr(yaml::Hex32(0)));
----------------
This is failing on MSVC builds:

```
E:\llvm\llvm-project\llvm\include\llvm/ADT/Optional.h(298): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
E:\llvm\llvm-project\llvm\lib\ObjectYAML\XCOFFEmitter.cpp(356): note: see reference to function template instantiation 'T llvm::Optional<T>::getValueOr<llvm::yaml::Hex32>(U &&) const &' being compiled
        with
        [
            T=llvm::yaml::Hex64,
            U=llvm::yaml::Hex32
        ]
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111487/new/

https://reviews.llvm.org/D111487



More information about the llvm-commits mailing list