[PATCH] D113434: [fir] Add complex operations conversion from FIR LLVM IR

Tue Nov 9 02:01:19 PST 2021

clementval added a comment.

In D113434#3117776 <https://reviews.llvm.org/D113434#3117776>, @kiranchandramohan wrote:

> What triple will this assume by default? Does it depend on the platform that it runs? Will this fail on AArch64? I think tco assumed x86_64 if not specified.

The conversion is the same for all target on this. `complexMemoryType` is shared for all targets.

================
Comment at: flang/test/Fir/types-to-llvm.fir:91
+// CHECK-SAME: !llvm.struct<(f64, f64)>)
+
+func private @foo3(%arg0: !fir.complex<16>)
----------------
kiranchandramohan wrote:
> Nit: kind 3, 10 are not handled.
Added. bf16 was needed in `fromRealTypeID` for kind 3

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113434/new/

https://reviews.llvm.org/D113434