[PATCH] D113434: [fir] Add complex operations conversion from FIR LLVM IR

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

What triple will this assume by default? Does it depend on the platform that it runs? Will this fail on AArch64? I think tco assumed x86_64 if not specified.



================
Comment at: flang/lib/Optimizer/CodeGen/TypeConverter.h:221
+      return mlir::FloatType::getF16(&getContext());
+    case llvm::Type::TypeID::FloatTyID:
+      return mlir::FloatType::getF32(&getContext());
----------------
Nit: should the bfloat type be here?


================
Comment at: flang/test/Fir/types-to-llvm.fir:91
+// CHECK-SAME: !llvm.struct<(f64, f64)>)
+
+func private @foo3(%arg0: !fir.complex<16>)
----------------
Nit: kind 3, 10 are not handled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113434/new/

https://reviews.llvm.org/D113434