[PATCH] D113466: [ELF] Improve sh_info=0 and sh_info>=num_sections diagnostic for SHT_REL/SHT_RELA

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 9 01:26:08 PST 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

One suggestion, otherwise LGTM.



================
Comment at: lld/ELF/InputFiles.cpp:856
+
+  error(toString(this) + ": relocation section (index " + Twine(idx) +
+        ") has invalid sh_info (" + Twine(info) + ")");
----------------
I feel like it might be useful to include the section name here, if it's practical.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113466/new/

https://reviews.llvm.org/D113466



More information about the llvm-commits mailing list