[PATCH] D112450: support xcoff for llvm-nm

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/basic.test:41
+
+# NM-SYM:      00000240 T ._GLOBAL__I_65535_0_v
+# NM-SYM-NEXT: 000001e4 t ._GLOBAL__sub_I_v
----------------
Coming back to this list of symbols: there are too many, and I doubt you need all of them for your test cases. I'd suggest the following:

1) Consider using assembly if you can as your input, as this will give you greater control over your symbol names and properties.
2) Only have one symbol for each possible code path through the llvm-nm code. 90% of these symbols look like they're just adding noise, and no value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112450/new/

https://reviews.llvm.org/D112450