[PATCH] D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections

Mon Nov 8 22:16:00 PST 2021

MaskRay added a comment.

> To me it seems like this should be reverted in main so that we can come up with a transition plan for the new functionality that everyone can agree on, but I also think adding a CMake option to control the behavior would be OK as long as the default was the old behavior.
>
> @MaskRay I understand your motivation for keeping this change, but I think lld is too popular at this point to make this kind of change without a longer transition plan for users to adjust.  I am also concerned about the possibility that this would break gcc + lld, and it would be nice to have more testing here (I can help with this if you want since this is a configuration I care about).

@tstellar The point I repeated multiple times is that I think the blast radius is very small.
People kept ignoring that there isn't much software relying on the GNU ld>=2015-10 behavior.
One (but not all) argument this is rare is: projects with gcc+lld problems have problems with gcc+GNU ld<2015-10, too.
The evidence from many big groups adopting rolling-released LLD is another major argument.

Surely I want to make LLD work for more components of GNU toolchain (please find the various GCC fixes I have made and the glibc 2.35 with LLD 13 work I did).
I tried to be impartial with the information I collected. See all the points I said to theraven.

Some people exaggerated the problem.
They found ldc and NetworkManager and tried to generalize that to more things.
Sorry, it doesn't generalize that way.

I would even say (for my previous message): if you wanted to revert release/13.x,
show evidence that sufficient software has gcc+LLD 13.x regression (compared with LLD 12.x) (because I don't think so).
I didn't say that but rather gave a green light for a release/13.x revert to pull myself outside of the unnecessary debate.
I said that I received comments. I did mean that.

For main, a revert-on-main would be a BIG regression on Clang+LLD metadata section usability.
Please don't do that.

If people want to add a CMake option on release/13.x, that works fine with me,
too, if distro people are just so fond of adding more complexity to the upstream
to avoid any even temporary local patch they may carry.

(I had a Xfinity network problem so might be slow to reply.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96914/new/

https://reviews.llvm.org/D96914