[PATCH] D112971: [NFC] Remove LinkAll*.h

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 8 22:01:50 PST 2021


dblaikie added a comment.

In D112971#3117441 <https://reviews.llvm.org/D112971#3117441>, @dblaikie wrote:

> My understanding is that this is necessary for the legacy pass manager that uses a global registration system - if you didn't reference any function in the pass, then the code wouldn't get linked in - because the only way the pass was accessed was through the registry?
>
> Does that sound right? Did this change break some legacy pass manager registry functionality? Am I just generally misremembering/misunderstanding how this worked or something changed to remove that model entirely?

Oh, I see, you caught that and reverted it for that reason - no worries then!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112971/new/

https://reviews.llvm.org/D112971



More information about the llvm-commits mailing list