[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

Thanks! Last nits: can we remove the `dup-symbols-weak-def.s` test now since the new logic is already covered by weak-definition-gc.s, and can we update the commit message to reflect the new approach?



================
Comment at: lld/MachO/SymbolTable.cpp:83
+          concatIsec->wasCoalesced = true;
+          concatIsec->symbols.erase(llvm::find(concatIsec->symbols, defined));
+        }
----------------
IMO this is redundant since we should never be using coalesced sections in any meaningful capacity. Maybe comment it out and leave a note as to why it's not needed?


================
Comment at: lld/test/MachO/weak-definition-gc.s:83-85
+# RUN: llvm-objdump --macho --syms --unwind-info %t/weak-strong-mixed.dylib | FileCheck  --check-prefix=MIXED-UNWIND %s
+# RUN: llvm-objdump --macho --syms --unwind-info %t/strong-weak-mixed.dylib | FileCheck  --check-prefix=MIXED-UNWIND %s
+# MIXED-UNWIND: g     F __TEXT,__text _foo
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112977/new/

https://reviews.llvm.org/D112977