[PATCH] D110555: [SPARC] Zero-extend the operands when doing UMULO on 64-bit integers

LemonBoy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 8 09:37:45 PST 2021


LemonBoy added a comment.

The fix LGTM, there's only a minor nit wrt the test placement.



================
Comment at: llvm/test/CodeGen/SPARC/mulo-64-lowering.ll:1
+; RUN: llc -march=sparcv9 < %s | FileCheck %s
+
----------------
Generate this file using `update_llc_test_checks.py`, that way it's much easier to update it if needed.

Minor nit to keep the test suite tidy, the unsigned case is already handled in `umulo-128-legalisation-lowering.ll`, perhaps copy-paste that and call it `smulo-128-legalisation-lowering.ll`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110555/new/

https://reviews.llvm.org/D110555



More information about the llvm-commits mailing list