[PATCH] D113395: [flang][CodeGen] Transform `IsPresentOpConversion` and `AbsentOpConversion`

Mon Nov 8 09:04:36 PST 2021

awarzynski added inline comments.

================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:25
 #include "llvm/ADT/ArrayRef.h"
+#include <mlir/Dialect/LLVMIR/LLVMDialect.h>

----------------
clementval wrote:
> Why is this suddenly needed? We have been creating LLVM ops until now without this extra include. Also it feels weird to not use quotes here. 
It's not, sorry. Must have crept in when I was working on some other thing. 

================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:86
+    mlir::Type ty = convertType(absent.getType());
+    mlir::Location loc = absent.getLoc();
+
----------------
clementval wrote:
> Fine if you want to update `auto` usage from `fir-dev` here. `getLoc()` is most of the time used with `auto` even in MLIR code base. 
> 
> Don't forget to sync back in fir-dev. 
> Don't forget to sync back in fir-dev.

I've made similar changes elsewhere as well. Let me send them to `fie-dev` as one bigger patch (to minimise the traffic). Shall I do it once all of the conversions in this file are complete?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113395/new/

https://reviews.llvm.org/D113395