[PATCH] D113366: [InstCombine] Canonicalize range test idiom

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 8 06:21:41 PST 2021


spatel accepted this revision.
spatel added a comment.

LGTM
If I'm seeing it correctly, this is currently limited to ignore a canonical umax pattern from somewhere higher in the callers. We must have a test for that pattern somewhere, so it would be nice to put an explanatory comment on that (currently negative) test along with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113366/new/

https://reviews.llvm.org/D113366



More information about the llvm-commits mailing list