[PATCH] D113288: [fir] Add fir.box type conversion

Mon Nov 8 04:17:24 PST 2021

clementval marked an inline comment as done.
clementval added inline comments.

================
Comment at: flang/test/Fir/types-to-llvm.fir:34
+func private @foo1(%arg0: !fir.box<!fir.array<10xf32>>)
+// CHECK: !llvm.ptr<struct<(ptr<array<10 x f32>>, i{{.*}}, i{{.*}}, i{{.*}}, i{{.*}}, i{{.*}}, i{{.*}}, array<1 x array<3 x i{{.*}}>>)>>
+
----------------
awarzynski wrote:
> IIUC, we won't be able to check the actual type of `i{{.*}}` until https://bugs.llvm.org/show_bug.cgi?id=52418  is resolved. Could you add a comment?
These tests are meant to be target agnostic in this form. We will probably add new check lines with specific prefix when we will check these types. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113288/new/

https://reviews.llvm.org/D113288