[PATCH] D111487: [XCOFF][yaml2obj] support for the auxiliary file header.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

Two minor comments, otherwise LGTM.



================
Comment at: llvm/test/tools/yaml2obj/XCOFF/aux-hdr-defaults.yaml:17
+# CASE1-NEXT:   Entry point address: 0x0
+# CASE1-NEXT:   .text section start address: 0x0
+# CASE1-NEXT:   .data section start address: 0xC
----------------
Could we add something before .text so that the .text section start address is non-zero? (This may not make sense from a file format perspective, so fine if not)


================
Comment at: llvm/test/tools/yaml2obj/XCOFF/aux-hdr-defaults.yaml:50
+## Set two sections with different contents for a given type to
+## demonstrate the values in the aux header depend on the first one.
+  - Flags:       [ STYP_TEXT ]
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111487/new/

https://reviews.llvm.org/D111487