[PATCH] D113106: demangle xcoff label symbol for llvm-nm

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:642
+
+  Optional<std::string> Opt = demangle(Name);
+  if (Opt)
----------------
Use a better variable name that describes what this represents, rather than describing its entity. Example: `Demangled`.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:645
+    return "." + *Opt;
+  else
+    return None;
----------------
Don't use `else` after `return`.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:636
+static Optional<std::string> demangleXCOFF(StringRef Name) {
+
+  if (!Name.empty() && Name[0] == '.')
----------------
jhenderson wrote:
> Nit: delete blank line at start of function.
I still see a blank line here at line 636.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113106/new/

https://reviews.llvm.org/D113106