[PATCH] D113349: [SCEV] Fix and validate ValueExprMap/ExprValueMap consistency

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D113349#3114647 <https://reviews.llvm.org/D113349#3114647>, @mkazantsev wrote:

> Can we split out refactoring + verifier changes (that expose some failues) and fixes for those failures? I'd like to see the tests and situations where they fail to make sure these functional fixes really address the problems. If those failures aren't too numerous or disrupting, please do.

The new verification makes pretty much all tests that verify SCEV fail. (This is a surprisingly low number, basically only LCSSA, LoopFuse and LoopUnrollAndJam tests, which use either `verify<scalar-evolution>` or explicitly call `SE.verify()`. Apparently the `-verify-scev` option doesn't do anything under the new pass manager...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113349/new/

https://reviews.llvm.org/D113349