[PATCH] D112725: [LoopVectorize] Extract the last lane from a uniform store

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.

Nice improvement @kmclaughlin, thanks for addressing my comments.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5475-5477
+      // A uniform memory op is itself uniform. Load instructions are added
+      // to the worklist as they demand the first lane. Since store instructions
+      // demand the last lane, we instead add these to Uniforms.
----------------
nit:  Should the comment on line 5443 be updated?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112725/new/

https://reviews.llvm.org/D112725