[PATCH] D113194: [DebugInfo][NFC] Prevent some tests from running in instruction-referencing mode

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 09:49:43 PDT 2021


dblaikie added a comment.

> The risk is that not all get converted and we lose test coverage in the long term; if that's too high a risk, I can do the test conversion first.

That seems to only be an issue if the defaults are changed before these tests are cleaned up - if having all these tests flagged this way makes it easier for local/branched (not changes to the actual LLVM github repo) that seems fine, and it's a matter of policing/ensuring the defaults aren't changed in-tree until all this is cleaned up/well understood. The flag name seems readily greppable, so I don't think that's a huge risk so long as everyone involved is aware of/remembers/ensures these are addressed before any mainline default change is made.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113194/new/

https://reviews.llvm.org/D113194



More information about the llvm-commits mailing list