[PATCH] D112692: [RISCV] Generate pseudo instruction li

[wangpc via Phabricator via llvm-commits]

pcwang-thead added a comment.

In D112692#3105005 <https://reviews.llvm.org/D112692#3105005>, @jrtc27 wrote:

> Oh, I see, Alex's suggestion. I'm not convinced by that, if you're maintaining a significant downstream fork and you don't know how to batch-update tests then I don't know what to say other than you shouldn't be maintaining a significant downstream fork.



In D112692#3105011 <https://reviews.llvm.org/D112692#3105011>, @jrtc27 wrote:

> In D112692#3103087 <https://reviews.llvm.org/D112692#3103087>, @asb wrote:
>
>> We discussed this last week on the sync-up call and nobody else had concerns about a change like this. @compnerd (IIRC) noted that for changes like this, it's good practice for the commit message to explain how to update (so downstreams can easily do so). I think something like this:
>> `./llvm/utils/update_llc_test_checks.py --llc-binary=build/bin/llc $(grep -r -l -m1 -F '; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py' llvm/test/CodeGen/RISCV)`.
>>
>> I agree with @jrtc27 that the sanitizer changes don't belong in this patch.
>
> FYI, all the update scripts take a -u option so they'll only update tests that are tagged as being autogenerated by that particular script, so you just need to run `llvm/utils/update_llc_test_checks.py --llc-binary=build/bin/llc -u` on '*.ll' and '*.mir' within the directory.

Thanks for your advice, I haven't noticed this option. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112692/new/

https://reviews.llvm.org/D112692