[PATCH] D112692: [RISCV] Generate pseudo instruction li

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 07:23:04 PDT 2021


asb added a subscriber: compnerd.
asb added a comment.

We discussed this last week on the sync-up call and nobody else had concerns about a change like this. @compnerd (IIRC) noted that for changes like this, it's good practice for the commit message to explain how to update (so downstreams can easily do so). I think something like this:
`./llvm/utils/update_llc_test_checks.py --llc-binary=build/bin/llc $(grep -r -l -m1 -F '; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py' llvm/test/CodeGen/RISCV)`.

I agree with @jrtc27 that the sanitizer changes don't belong in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112692/new/

https://reviews.llvm.org/D112692



More information about the llvm-commits mailing list