[PATCH] D110616: [Legalizer] Expand BR_CC into SETCC if condition code is legal

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 7 17:44:24 PST 2021


shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3714
+    // If the condition code is legal, try split BR_CC into SETCC with new BR_CC.
+    if (!Legalized) {
+      ISD::CondCode CC = cast<CondCodeSDNode>(Tmp4)->get();
----------------
Just curious, will it be possible that the new `BR_CC` is still not legalized? And thus leading to an infinite loop here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110616/new/

https://reviews.llvm.org/D110616



More information about the llvm-commits mailing list