[PATCH] D113241: [lld-macho][nfc] rename parsed-section types & variables

Vincent Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 7 13:19:06 PST 2021


thevinster added a comment.

> OTOH, SegmentCommand is not overloaded, and used only once. Nlist is not overloaded, and isn't even a header but rather an element in a vector.

Makes sense. I guess what I was getting at is whether we can make it more obvious that Nlist or SegmentCommand are structures defined from `MachOStructs.h`. If this is the best we can do, then it's fine as is, but assuming we could find such a pattern, then it could also apply to `Section` to make it consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113241/new/

https://reviews.llvm.org/D113241



More information about the llvm-commits mailing list